From 5c50174212c73e585b2b27f1bb952f77b8bfb077 Mon Sep 17 00:00:00 2001 From: ENGO150 Date: Fri, 27 Jan 2023 15:10:20 +0100 Subject: [PATCH] fixed one remaining memory leak from checkVersion lmao I thought the memory leak was bug in json-c :DD --- src/core/lib/misc.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/core/lib/misc.c b/src/core/lib/misc.c index c05b313..e91b9c1 100644 --- a/src/core/lib/misc.c +++ b/src/core/lib/misc.c @@ -161,7 +161,7 @@ boolean checkVersion(void) fclose(fileBuffer); //GET - parsedJson = json_tokener_parse(buffer); + parsedJson = json_tokener_parse(buffer); //yes, ik, i could use json_object_from_file, but I need to check for internet somehow json_object_object_get_ex(parsedJson, "active", &active); if (strcmp(VERSION, json_object_get_string(active)) != 0) @@ -248,7 +248,6 @@ boolean checkVersion(void) { if (!getFlags().noOutput) printf("Version %s not found! Check your flags.\n\n", VERSION); - free(deprecated); goto deallocation; } @@ -258,15 +257,13 @@ boolean checkVersion(void) if (!getFlags().noOutput) fprintf(stderr, "This release could be unsafe! You're %d versions behind! (%s/%s)\n\n", versionsBuffer, VERSION, json_object_get_string(active)); //WAIT FOR 5 SECONDS - free(deprecated); sleep(5); } deallocation: //DEALLOCATION - free(parsedJson); - free(active); + json_object_put(parsedJson); //THIS FREES EVERY json_object - AT LEAST JSON-C'S DOCUMENTATION SAYS THAT free(buffer); return SUCCESS;